Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat. simulation codes for canto modules #65

Merged
merged 27 commits into from
Jul 26, 2024
Merged

feat. simulation codes for canto modules #65

merged 27 commits into from
Jul 26, 2024

Conversation

poorphd
Copy link

@poorphd poorphd commented Jul 8, 2024 •
edited
Loading

Description

  • RandomizedParams has been removed from the AppModuleSimulation interface.
  • Simulation codes for Canto modules are added

Closes: L-2, L-7

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@poorphd poorphd requested a review from dudong2 July 8, 2024 14:52
@poorphd poorphd self-assigned this Jul 9, 2024
@poorphd poorphd mentioned this pull request Jul 9, 2024
Closed
10 tasks
@poorphd poorphd force-pushed the patch/simulation branch from 2887303 to 436b74b Compare July 9, 2024 14:41
@poorphd poorphd force-pushed the patch/simulation branch from 436b74b to df52384 Compare July 9, 2024 14:47
@poorphd poorphd closed this Jul 9, 2024
@poorphd
Copy link
Author

poorphd commented Jul 9, 2024

need to fix coinswap simulation

@poorphd poorphd removed the request for review from dudong2 July 9, 2024 14:50
@poorphd poorphd reopened this Jul 10, 2024
@poorphd
Merge remote-tracking branch 'refs/remotes/origin/v8/develop' into pa…
9c8ad99 
…tch/simulation

# Conflicts:
#	x/erc20/module.go
#	x/govshuttle/module.go
#	x/inflation/module.go
@poorphd poorphd requested review from dudong2 and zsystm July 19, 2024 05:31
@poorphd poorphd marked this pull request as ready for review July 19, 2024 05:31
poorphd added 2 commits July 24, 2024 13:48
@poorphd
Merge branch 'v8/develop' into patch/simulation
9e696e8 
# Conflicts:
#	app/app.go
#	x/coinswap/simulation/operation.go
#	x/coinswap/types/msgs.go
#	x/erc20/module.go
@poorphd
fix: msg route registeration
45ac147
@poorphd poorphd force-pushed the patch/simulation branch from f5ddab1 to 45ac147 Compare July 24, 2024 04:57
zsystm
zsystm reviewed Jul 25, 2024
View reviewed changes
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poorphd

  • coinswap operations always fail
  • minor comments for code

x/erc20/simulation/proposal.go Outdated Show resolved Hide resolved
x/erc20/types/utils.go Show resolved Hide resolved
x/coinswap/simulation/operation.go Outdated Show resolved Hide resolved
@poorphd poorphd requested a review from zsystm July 25, 2024 13:50
zsystm
zsystm approved these changes Jul 26, 2024
View reviewed changes
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2
Copy link

dudong2 commented Jul 26, 2024

need to implement RegisterStoreDecoder for all modules that have NewDecodeStore function.
ref. https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/x/staking/module.go#L292-L295

@dudong2
Copy link

dudong2 commented Jul 26, 2024

need to check interface about module.AppModuleSimulation for all AppModules.
ref. https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/x/staking/module.go#L41

dudong2
dudong2 reviewed Jul 26, 2024
View reviewed changes
x/coinswap/types/msgs.go Outdated Show resolved Hide resolved
@poorphd
Copy link
Author

poorphd commented Jul 26, 2024

need to implement RegisterStoreDecoder for all modules that have NewDecodeStore function. ref. https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/x/staking/module.go#L292-L295

applied in 6d15af1

@poorphd
Copy link
Author

poorphd commented Jul 26, 2024

need to check interface about module.AppModuleSimulation for all AppModules. ref. https://github.com/cosmos/cosmos-sdk/blob/v0.50.8/x/staking/module.go#L41

applied in 096d7d1

@poorphd poorphd requested a review from dudong2 July 26, 2024 08:23
@poorphd poorphd force-pushed the patch/simulation branch from e7838ed to 1c5079b Compare July 26, 2024 08:53
dudong2
dudong2 approved these changes Jul 26, 2024
View reviewed changes
Copy link

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poorphd poorphd merged commit 471c41a into v8/develop Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsystm zsystm zsystm approved these changes

@dudong2 dudong2 dudong2 approved these changes

Assignees

@poorphd poorphd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QA Report
3 participants
@poorphd @dudong2 @zsystm